diff options
| author | Henrik S. Gaßmann <[email protected]> | 2023-12-02 15:19:30 +0100 |
|---|---|---|
| committer | Jack O'Connor <[email protected]> | 2023-12-02 11:11:10 -0800 |
| commit | 7ce2aa41e9f01a91c3b309a7bf5e86b4136ed8a9 (patch) | |
| tree | fe2f8d8a3dfebc8f0a357bf45a1711e8907fe064 | |
| parent | 92e4cd71be48fdf9a79e88ef37b8f415ec5ac210 (diff) | |
build(CMake): Require C99 mode
Specify language requirement as a [compile-feature] and force compiler
extensions off ensuring portability problems are detected early on.
Note that we do not use the `C_STANDARD` property, because it doesn't
propagate to dependent targets and would prohibit users from compiling
their code base with consistent flags / language configuations if they
were to target a newer C standard. Similarly we do not configure
`C_STANDARD_REQUIRED` as [compile-features] do not interact with
it--they are enforced regardless.
[compile-feature]: https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html#compile-feature-requirements
| -rw-r--r-- | c/CMakeLists.txt | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/c/CMakeLists.txt b/c/CMakeLists.txt index 49cde64..8f38144 100644 --- a/c/CMakeLists.txt +++ b/c/CMakeLists.txt @@ -1,4 +1,9 @@ -cmake_minimum_required(VERSION 3.9) +cmake_minimum_required(VERSION 3.9 FATAL_ERROR) + +# respect C_EXTENSIONS OFF without explicitly setting C_STANDARD +if (POLICY CMP0128) + cmake_policy(SET CMP0128 NEW) +endif() project(libblake3 VERSION 1.5.0 @@ -61,7 +66,14 @@ set_target_properties(blake3 PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION 0 C_VISIBILITY_PRESET hidden + C_EXTENSIONS OFF ) +target_compile_features(blake3 PUBLIC c_std_99) +# ensure C_EXTENSIONS OFF is respected without overriding CMAKE_C_STANDARD +# which may be set by the user or toolchain file +if (NOT POLICY CMP0128 AND NOT DEFINED CMAKE_C_STANDARD) + set_target_properties(blake3 PROPERTIES C_STANDARD 99) +endif() # optional SIMD sources macro(BLAKE3_DISABLE_SIMD) |