| Age | Commit message (Collapse) | Author |
|---|
|
* Rename out() to Output()
This brings behavior inline with go's flag library, and allows for
printing output directly to whatever the current FlagSet is using for
output. This change will make it easier to correctly emit output to
stdout or stderr (e.g. a user has requested a help screen, which
should emit to stdout since it's the desired outcome).
* improve compat. with pkg/flag by adding Name()
pkg/flag has a public `Name()` function, which returns the name of the
flag set when called. This commit adds that function, as well as a
test for it.
* Streamline testing Name()
Testing `Name()` will move into its own explicit test, instead of
running inline during `TestAddFlagSet()`.
Co-authored-by: Chloe Kudryavtsev <[email protected]>
Co-authored-by: Chloe Kudryavtsev <[email protected]>
|
|
Implement SliceValue for better list semantics
|
|
|
|
|
|
Signed-off-by: David Schneider <[email protected]>
|
|
Signed-off-by: Oren Shomron <[email protected]>
|
|
Based on patch suggested here: https://github.com/spf13/cobra/issues/597#issuecomment-385984076
|
|
|
|
They have to explicitly unhide a deprecated flag to keep the current behavior.
|
|
* make GoFlagSets.Parsed() true after pflag.Parse
some third part lib such as glog use go flag package, and its some
actions depends on if goflag.Parsed().
* add test case for goflag.CommandLine.Parsed()
* add comment to goflag.CommandLine.Parsed test case
|
|
* add ability to ignore unknown flags
* add testcases
* add 2 more patterns to the testcase
* handle --unknownflag=val arg and -u=val arg scenario
* add ParseErrorsWhiteList to extend error handling during parsing
|
|
* Add multiline wrapping support
With reference to golang/go#20799, pflag now will respect newline in usage string and do wrap accordingly. Also add test cases for testing
* Break at \n only if \n pos<wrap
|
|
|
|
|
|
|
|
Related to https://github.com/spf13/cobra/issues/521
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
See https://github.com/spf13/cobra/issues/27#issuecomment-294690084
|
|
|
|
|
|
|
|
|
|
In some cases "exists" is better to understand
|
|
Cache sorted flags
|
|
Removed unused field "exitOnError".
|
|
Change `ogier` to `spf13` in docs and README
|
|
As you can't delete flags in FlagSet, this method works
Gainful performance improvement:
benchmark old ns/op new ns/op delta
BenchmarkVisitAll10Flags-4 1549 33.9 -97.81%
BenchmarkVisit10Flags-4 1704 34.2 -97.99%
benchmark old allocs new allocs delta
BenchmarkVisitAll10Flags-4 3 0 -100.00%
BenchmarkVisit10Flags-4 3 0 -100.00%
benchmark old bytes new bytes delta
BenchmarkVisitAll10Flags-4 272 0 -100.00%
BenchmarkVisit10Flags-4 272 0 -100.00%
|
|
Fix #120
|
|
|
|
Fixes https://github.com/spf13/cobra/issues/316
|
|
|
|
This will allow applications to provide better help text without feeling
constrained by how it will wrap even on 80 column displays etc. This has been a
factor in tickets such as https://github.com/docker/docker/issues/18797.
The basic wrapping algorithm is rather simplistic, it will look for the last
whitespace (space or tab) before the given column and wrap there, indenting the
continuation lines to match the usage text (i.e. aligned after the flag names
themselves), e.g. when applied to `docker ps` wrapping at 70 columns (fairly
narrow):
Options:
[...]
-f, --filter filter Filter output based on conditions provided
[...]
-n, --last int Show n last created containers
(includes all states) (default -1)
-l, --latest Show the latest created container
(includes all states)
There are two main tweaks to this basic algorithm, first is to actually try and
wrap to a soft limit 5 columns less than requested but allow the line to take
up the full hard width if that prevents pushing a short word at the end of the
string to the next line which looks odd, particuarly for usage which ends with
"(default [])" and wraps the "[])" to the last line.
Second if the display is too narrow, meaning after indentation for the flag
names there is less than 24 columns allowed for the help text (24 chosen just
by my eye and what I thought looked odd) then it will start the help text on
the next line indented to the 16th column (16 chosen so as not to align with
the first character of either the short of long flag name as 8 would, since
that looked strange to me), e.g. wrapping the above example to a rather narrow
45 columns:
Options:
[...]
-f, --filter filter
Filter output based on
conditions provided
[...]
-n, --last int
Show n last created
containers (includes
all states) (default -1)
-l, --latest
Show the latest
created container
(includes all states)
If even with starting the help on the next line there is still less than 24
characters of space available for the help text (implying columns < 24 + 16 ==
40) just give up and return the unwrapped version (same as before this change).
Signed-off-by: Ian Campbell <[email protected]>,
|
|
Clean up code
|
|
We basically want to allow callers to use our command line parser. There
is a user who wants to log the command line, but they don't want to log
"sensitive" flags. This allows that user to parse the command line and
get each flag. They can use information in the flag to write their own
printer.
|
|
|
|
default is set.
Signed-off-by: Daniel Nephin <[email protected]>
|
|
Signed-off-by: Daniel Nephin <[email protected]>
|
|
|
|
Fallback to the original default detection logic if we have an unknown
type.
Fixes #91
|
|
|
|
In Go 1.7 the default value for a time.Duration will change from "0" to
"0s". This commit replaces the simplistic `isZeroValue` with a more
intelligent implementation that checks for zero values based
upon the specific type of the flag.
|
