From 9a97c102cda95a86cec2345a6f09f55a939babf5 Mon Sep 17 00:00:00 2001
From: Gorka Lerchundi Osa <glertxundi@gmail.com>
Date: Wed, 8 Aug 2018 17:28:24 +0200
Subject: bytes: add support for base64 encoded flags (#177)

Signed-off-by: Gorka Lerchundi Osa <glertxundi@gmail.com>
---
 bytes_test.go | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 63 insertions(+), 1 deletion(-)

(limited to 'bytes_test.go')

diff --git a/bytes_test.go b/bytes_test.go
index cc4a769..5251f34 100644
--- a/bytes_test.go
+++ b/bytes_test.go
@@ -1,6 +1,7 @@
 package pflag
 
 import (
+	"encoding/base64"
 	"fmt"
 	"os"
 	"testing"
@@ -61,7 +62,7 @@ func TestBytesHex(t *testing.T) {
 			} else if tc.success {
 				bytesHex, err := f.GetBytesHex("bytes")
 				if err != nil {
-					t.Errorf("Got error trying to fetch the IP flag: %v", err)
+					t.Errorf("Got error trying to fetch the 'bytes' flag: %v", err)
 				}
 				if fmt.Sprintf("%X", bytesHex) != tc.expected {
 					t.Errorf("expected %q, got '%X'", tc.expected, bytesHex)
@@ -70,3 +71,64 @@ func TestBytesHex(t *testing.T) {
 		}
 	}
 }
+
+func setUpBytesBase64(bytesBase64 *[]byte) *FlagSet {
+	f := NewFlagSet("test", ContinueOnError)
+	f.BytesBase64Var(bytesBase64, "bytes", []byte{1, 2, 3, 4, 5, 6, 7, 8, 9, 0}, "Some bytes in Base64")
+	f.BytesBase64VarP(bytesBase64, "bytes2", "B", []byte{1, 2, 3, 4, 5, 6, 7, 8, 9, 0}, "Some bytes in Base64")
+	return f
+}
+
+func TestBytesBase64(t *testing.T) {
+	testCases := []struct {
+		input    string
+		success  bool
+		expected string
+	}{
+		/// Positive cases
+		{"", true, ""}, // Is empty string OK ?
+		{"AQ==", true, "AQ=="},
+
+		// Negative cases
+		{"AQ", false, ""}, // Padding removed
+		{"ï", false, ""},  // non-base64 characters
+	}
+
+	devnull, _ := os.Open(os.DevNull)
+	os.Stderr = devnull
+
+	for i := range testCases {
+		var bytesBase64 []byte
+		f := setUpBytesBase64(&bytesBase64)
+
+		tc := &testCases[i]
+
+		// --bytes
+		args := []string{
+			fmt.Sprintf("--bytes=%s", tc.input),
+			fmt.Sprintf("-B  %s", tc.input),
+			fmt.Sprintf("--bytes2=%s", tc.input),
+		}
+
+		for _, arg := range args {
+			err := f.Parse([]string{arg})
+
+			if err != nil && tc.success == true {
+				t.Errorf("expected success, got %q", err)
+				continue
+			} else if err == nil && tc.success == false {
+				// bytesBase64, err := f.GetBytesBase64("bytes")
+				t.Errorf("expected failure while processing %q", tc.input)
+				continue
+			} else if tc.success {
+				bytesBase64, err := f.GetBytesBase64("bytes")
+				if err != nil {
+					t.Errorf("Got error trying to fetch the 'bytes' flag: %v", err)
+				}
+				if base64.StdEncoding.EncodeToString(bytesBase64) != tc.expected {
+					t.Errorf("expected %q, got '%X'", tc.expected, bytesBase64)
+				}
+			}
+		}
+	}
+}
-- 
cgit v1.2.3