From d16d05ecad8d146ef127c975e2e3e167b6e38ad6 Mon Sep 17 00:00:00 2001 From: bogem Date: Sat, 10 Sep 2016 12:08:47 +0500 Subject: Use strconv instead of fmt in values' String funcs The existing implementation of flag values with fmt package uses more memory and works slower than the implementation with strconv package. --- int32.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'int32.go') diff --git a/int32.go b/int32.go index 41659a9..9b95944 100644 --- a/int32.go +++ b/int32.go @@ -1,9 +1,6 @@ package pflag -import ( - "fmt" - "strconv" -) +import "strconv" // -- int32 Value type int32Value int32 @@ -23,7 +20,7 @@ func (i *int32Value) Type() string { return "int32" } -func (i *int32Value) String() string { return fmt.Sprintf("%v", *i) } +func (i *int32Value) String() string { return strconv.FormatInt(int64(*i), 10) } func int32Conv(sval string) (interface{}, error) { v, err := strconv.ParseInt(sval, 0, 32) -- cgit v1.2.3